Re: [PATCH 13/16] GFS2: Makefiles and Kconfig

[Steven Whitehouse <swhiteho@redhat.com>]

Hi,

On Fri, 2006-04-21 at 16:00 -0700, Greg KH wrote:
> On Fri, Apr 21, 2006 at 06:43:09PM +0200, Adrian Bunk wrote:
> > > --- /dev/null
> > > +++ b/fs/gfs2/Kconfig
> > > @@ -0,0 +1,46 @@
> > > +config GFS2_FS
> > > +        tristate "GFS2 file system support"
> > > +	default m
> > > +	depends on EXPERIMENTAL
> > > +        select FS_POSIX_ACL
> > > +        select SYSFS
> > >...
> > 
> > - tabs <-> spaces (tabs are correct)
> > - please remove the "default m"
> > - "depends on SYSFS" instead of the select
> 
> Why do you depend on sysfs at all?  If it's not enabled, your code
> should still build just fine, right?  If not, please let us know and we
> will fix the build error in the sysfs.h header file.
> 
> thanks,
> 
> greg k-h

I've removed this dependency now. Thanks for pointing this out,

Steve.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/