Re: [PATCH] binfmt_elf CodingStyle cleanup and remove some pointless casts

On 4/23/06, Andrew Morton <[email protected]> wrote:
> Jesper Juhl <[email protected]> wrote:
> >
> > Here's a patch that does a CodingStyle cleanup of fs/binfmt_elf.c and also
> > removes some pointless casts of kmalloc() return values in the same file.
> >
>
> Much-needed.
>
Nice to know that doing it was worthwhile :)


[snip]
> The typecasting for NEW_AUX_ENT is random, ugly, irrational and
> undesirable.  It's always u32 or unsigned long.  Perhaps as a followup
> patch you could look at removing the unneeded casts? (hopefully that'll
> be all of them)
>
Sure, I'll take a look at that this evening, hopefully that'll mean a
follow-up patch in aproximately 12-16hrs.


--
Jesper Juhl <[email protected]>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] binfmt_elf CodingStyle cleanup and remove some pointless casts
    • From: Jesper Juhl <[email protected]>

• References:
  • [PATCH] binfmt_elf CodingStyle cleanup and remove some pointless casts
    • From: Jesper Juhl <[email protected]>
  • Re: [PATCH] binfmt_elf CodingStyle cleanup and remove some pointless casts
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [RFC][PATCH 0/11] security: AppArmor - Overview
• Next by Date: [NFSD]: Select things at the closest tristate instead of bool
• Previous by thread: Re: [PATCH] binfmt_elf CodingStyle cleanup and remove some pointless casts
• Next by thread: Re: [PATCH] binfmt_elf CodingStyle cleanup and remove some pointless casts
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]