Re: [FIX] ide-io: increase timeout value to allow for slave wakeup

[Mark Lord <liml@rtr.ca>]

Al Boldi wrote:
..
> Also apply this one to get rid of this message:
>
> 	hdb: set_drive_speed_status: status=0x40 { DriveReady }
> 	ide: failed opcode was: unknown
>
> Maybe someone on the ide list can comment on this first though.
>
> --- 16/include/linux/ide.h.orig	2006-03-31 19:12:51.000000000 +0300
> +++ 16/include/linux/ide.h	2006-04-23 13:06:32.000000000 +0300
> @@ -120,7 +120,7 @@ typedef unsigned char	byte;	/* used ever
>  #define IDE_BCOUNTL_REG		IDE_LCYL_REG
>  #define IDE_BCOUNTH_REG		IDE_HCYL_REG
>  
> -#define OK_STAT(stat,good,bad)	(((stat)&((good)|(bad)))==(good))
> +#define OK_STAT(stat,good,bad)	(((stat)&((good)|(bad)))==((stat)&(good)))
>  #define BAD_R_STAT		(BUSY_STAT   | ERR_STAT)
>  #define BAD_W_STAT		(BAD_R_STAT  | WRERR_STAT)
>  #define BAD_STAT		(BAD_R_STAT  | DRQ_STAT)

Assuming hdb is a CDROM/optical drive, then this change makes sense for that.
But I don't think it is a valid (good) change for regular ATA disks.

A more complex patch is required, one which correctly handles each drive type.

cheers
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/