Hi Pekka,
> I have included some review comments below.
First of all thank you very much for the code review! You suggestions
sound reasonable! I will post an updated patch on Monday!
[snip]
> > +struct x_info_blk_hdr {
> > + __u8 npar;
> > + __u8 flags;
> > + __u16 tslice;
> > + __u16 phys_cpus;
> > + __u16 this_part;
> > + __u64 curtod1;
> > + __u64 curtod2;
> > + char reserved[40];
> > +} __attribute__ ((packed));
>
> Couldn't you use endianess annotated types for these?
>
What are "endianess annotated types" ?
Michael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
