Re: [uml-devel] [PATCH 1/3] UML - Change sigjmp_buf to jmp_buf

[Blaisorblade <blaisorblade@yahoo.it>]

On Tuesday 11 April 2006 01:37, Jeff Dike wrote:
> Clean up the jmpbuf code.  Since softints, we no longer use sig_setjmp, so
> the UML_SIGSETJMP wrapper now has a misleading name.  Also, I forgot to
> change the buffers from sigjmp_buf to jmp_buf.

> Signed-off-by: Jeff Dike <jdike@addtoit.com>

Can I request (additionally) a look at remaining calls to {sig,}setjmp() and 
sigprocmask(), like the below one and the one in (IIRC) thread_wait()?

I think that probably some of them are valid because signal handlers modify 
the signal mask, so we may still need to play with it, but:

* I don't remember (I may be wrong) mention of this in the changelog of the 
softints patch,

* you had IIRC doubts on the current code (when I noted thread_wait())

* an analysis of what is correct should end up in a comment somewhere 
describing the results.

I won't have the time to work on this soon, at least not this week, and I 
didn't write the code.

When I'll get time, I'll work on merging RemapFilePages in -mm (I'm reasonably 
near to resend it, but I can't until I've made sure all changelogs are 
up-to-date and clear enough).

> Index: linux-2.6.16-mm/arch/um/os-Linux/util.c
> ===================================================================

>  int setjmp_wrapper(void (*proc)(void *, void *), ...)
>  {
>  	va_list args;
> -	sigjmp_buf buf;
> +	jmp_buf buf;
>  	int n;
>
>  	n = sigsetjmp(buf, 1);

-- 
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade


	

	
		
___________________________________ 
Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB 
http://mail.yahoo.it
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/