Re: [PATCH] sound: fix hang in mpu401_uart.c

At Wed, 19 Apr 2006 00:45:14 +0100,
Jon Masters wrote:
> 
> On 4/18/06, Takashi Iwai <[email protected]> wrote:
> 
> > > +             if ((err = snd_mpu401_uart_cmd(mpu, MPU401_RESET, 1))) {
> > > +                     return -EFAULT;
> >
> > IMO, -EFAULT isn't a good choice for this kind of error.
> 
> What would you suggest?

I would use -EIO.


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] sound: fix hang in mpu401_uart.c
    • From: Jon Masters <[email protected]>
  • Re: [PATCH] sound: fix hang in mpu401_uart.c
    • From: Takashi Iwai <[email protected]>
  • Re: [PATCH] sound: fix hang in mpu401_uart.c
    • From: "Jon Masters" <[email protected]>

• Prev by Date: VFS && UFS write support: possible on *BSD/Solaris, impossible on Linux?
• Next by Date: Re: [PATCH]drivers/char/cs5535_gpio.c:call cdev_del during module_exit to unmap kobject references and other cleanups.
• Previous by thread: Re: [PATCH] sound: fix hang in mpu401_uart.c
• Next by thread: Re: [PATCH] hci_usb: implement suspend/resume
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]