Hi. On Wednesday 19 April 2006 09:16, Andrew Morton wrote: > Nigel Cunningham <[email protected]> wrote: > > --- 9904.patch-old/kernel/sysctl.c 2006-04-19 08:40:47.000000000 +1000 > > +++ 9904.patch-new/kernel/sysctl.c 2006-04-17 21:06:23.000000000 +1000 > > @@ -401,7 +401,7 @@ static ctl_table kern_table[] = { > > .strategy = &sysctl_string, > > }, > > #endif > > -#ifdef CONFIG_HOTPLUG > > +#if defined(CONFIG_HOTPLUG) && defined(CONFIG_NET) > > I've had this in -mm for a couple of weeks now but rmk points out that it's > rather silly. Because if you have CONFIG_HOTPLUG=y, CONFIG_NET=n then the > kernel cannot deliver hotplug events to userspace.. > > So perhaps CONFIG_HOTPLUG should depend upon CONFIG_NET or, better, > CONFIG_NETLINK. > > Dunno. I left this in Greg's lap, but he's hiding. :) Ah okay. I guess he's been busy with those mini summits. Regards, Nigel
Attachment:
pgpIEkss1iMZ8.pgp
Description: PGP signature
- References:
- [PATCH] Kernel doesn't compile with CONFIG_HOTPLUG && !CONFIG_NET
- From: Nigel Cunningham <[email protected]>
- Re: [PATCH] Kernel doesn't compile with CONFIG_HOTPLUG && !CONFIG_NET
- From: Andrew Morton <[email protected]>
- [PATCH] Kernel doesn't compile with CONFIG_HOTPLUG && !CONFIG_NET
- Prev by Date: Re: [RESEND][RFC][PATCH 2/7] implementation of LSM hooks
- Next by Date: Re: [2.6 patch] fix dependencies of HUGETLB_PAGE_SIZE_64K
- Previous by thread: Re: [PATCH] Kernel doesn't compile with CONFIG_HOTPLUG && !CONFIG_NET
- Next by thread: Re: [PATCH] Kernel doesn't compile with CONFIG_HOTPLUG && !CONFIG_NET
- Index(es):
 |