On Tue, Apr 18, 2006 at 05:17:51PM +0200, Stelian Pop wrote:
> Le mardi 18 avril 2006 ?? 21:25 +0900, YOSHIFUJI Hideaki / ???????????? a
> ??crit :
> > In article <1145358431.14816.18.camel@localhost> (at Tue, 18 Apr 2006 13:07:11 +0200), Nicolas Boichat <[email protected]> says:
> >
> > > @@ -147,13 +164,22 @@ MODULE_PARM_DESC(debug, "Activate debugg
> > > /* Checks if the device a Geyser 2 (ANSI, ISO, JIS) */
> > > static inline int atp_is_geyser_2(struct atp *dev)
> > > {
> > > - int16_t productId = le16_to_cpu(dev->udev->descriptor.idProduct);
> > > + int productId = le16_to_cpu(dev->udev->descriptor.idProduct);
> > >
> > > return (productId == GEYSER_ANSI_PRODUCT_ID) ||
> > > (productId == GEYSER_ISO_PRODUCT_ID) ||
> > > (productId == GEYSER_JIS_PRODUCT_ID);
> > > }
> >
> > Any good reasons to change this?
>
> Because the use of a generic integer type is generally preferred over a
> fixed size type. And even if a fixed size was needed, u16/s16 would be
> more appropriate.
u16 is needed, s16 for USB ids is not correct.
And that int16_t crud is not correct either way :)
thanks,
greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
