ide-cd.c, "MEDIUM_ERROR" handling

[Zinx Verituse <zinx@epicsol.org>]

I recently bought a DVD drive which appears to not retry enough when it's
having trouble reading a disc - I'm requesting an option (or changing the
default behavior) so that this drive is actually usable with the Linux
ide-cd drivers - specificly, the code:
	} else if (sense_key == MEDIUM_ERROR) {
		/* No point in re-trying a zillion times on a bad
		 * sector...  If we got here the error is not correctable */
		ide_dump_status (drive, "media error (bad sector)", stat);
		do_end_request = 1;
	}
needs to be disabled for my drive to read CDs properly.

With this code enabled, no retries are made, and the kernel sees medium errors
and returns bad data to the application reading; without it, the kernel retries
transparently and reads the data perfectly.  So, I think the comment is
assuming decent hardware, which unfortunately isn't always what we have :/

I can make the patch for conditionally enabling/disabling it if needed.
I think it may make more sense to retry by default, but I don't know the
general state of modern cheap CD/DVD drives either.  It seems like it's
a corner case on hardware that does re-try a zillion times, though, so
probably won't greatly affect that hardware like it does the hardware
that doesn't re-try a zillion times.

I'm not on the list currently, so please CC me with any replies.

-- 
Zinx Verituse                                    http://zinx.xmms.org/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/