Re: [PATCH] sched: modify move_tasks() to improve load balancing outcomes

["Siddha, Suresh B" <suresh.b.siddha@intel.com>]

On Sat, Apr 15, 2006 at 10:54:45AM +1000, Peter Williams wrote:
> Yes, there are problems with the active/expired arrays but they're no 
> worse with smpnice than they are without it.

With smpnice, if we make any wrong decision while moving the high and
low priority tasks, we will enter an endless loop(as load balance
will keep on showing the imbalance and move_tasks will always move
the wrong tasks, instead of the correct ones pointed by imbalance..)

With the current code in the mainline, we don't have such a problem.

> Going to a single priority array would eliminate this problem not to 
> mention other problems to do with when to excuse tasks from being put on 
> the expired array at the end of their time slice (see Mike Galbraith's 
> patches).  But I haven't had much luck pushing that barrow. :-)

I will take a loot at those patches.

> If you have a better suggestion for how move_tasks() does its job, how 
> about providing a patch and with supporting arguments as to why its 
> better.  If it is better then we can use it.

I think we can have a second pass(if the first pass fails to move any),
in which we will not skip those tasks which will become highest priority
on the target runqueue...

> > The only special check in find_busiest_group() helping MT/MC balancing
> > is pwr_now and pwr_move calculations..
> 
> What about the very messy code I had to put in so that 
> find_busiest_group() would return a group even if there were no queues 
> in the group with more than one task.  Similar for find_busiest_queue().

Thats messy for sure and that was introduced by you to fix an imabalance
issue for a simple DP system(with out breaking HT systems). I will post a fix
for that.

thanks,
suresh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/