Re: [RFC: 2.6 patch] let arm use drivers/Kconfig

[David Woodhouse <dwmw2@infradead.org>]

On Mon, 2006-04-17 at 16:48 +0200, Adrian Bunk wrote:
> --- linux-2.6.17-rc1-mm2-arm/drivers/mtd/Kconfig.old    2006-04-17 14:32:35.000000000 +0200
> +++ linux-2.6.17-rc1-mm2-arm/drivers/mtd/Kconfig        2006-04-17 15:00:57.000000000 +0200
> @@ -1,6 +1,7 @@
>  # $Id: Kconfig,v 1.11 2005/11/07 11:14:19 gleixner Exp $
>  
>  menu "Memory Technology Devices (MTD)"
> +       depends on (ALIGNMENT_TRAP || !ARM)
>  
>  config MTD
>         tristate "Memory Technology Device (MTD) support"

This dependency is incorrect. It's only one or two chip-specific drivers
which require that the architecture correctly handle alignment traps,
and even then it's only actually apparent when used with JFFS2 which
actually _gives_ it an unaligned buffer occasionally. Everything else
works fine.

Also, I don't want to see this dependency expressed in the MTD Kconfig
file unless it's not arch-specific. Please make a generic
BROKEN_UNALIGNED config option, and set it on all architectures which
need it. Then propose a saner place to put the restriction instead of on
CONFIG_MTD.

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/