[PATCH] unaligned access in sk_run_filter()

[PATCH] unaligned access in sk_run_filter()

This patch fixes unaligned access warnings noticed on IA64
in sk_run_filter(). 'ptr' can be unaligned.

Signed-Off-By: Dmitry Mishin <[email protected]>
Signed-Off-By: Kirill Korotaev <[email protected]>

--- ./net/core/filter.c.ve125	2006-04-05 15:11:24.000000000 +0400
+++ ./net/core/filter.c	2006-04-05 15:55:33.000000000 +0400
@@ -34,6 +34,7 @@
 #include <linux/timer.h>
 #include <asm/system.h>
 #include <asm/uaccess.h>
+#include <asm/unaligned.h>
 #include <linux/filter.h>
 
 /* No hurry in this branch */
@@ -177,7 +178,7 @@ unsigned int sk_run_filter(struct sk_buf
 load_w:
 			ptr = load_pointer(skb, k, 4, &tmp);
 			if (ptr != NULL) {
-				A = ntohl(*(u32 *)ptr);
+				A = ntohl(get_unaligned((u32 *)ptr));
 				continue;
 			}
 			break;
@@ -186,7 +187,7 @@ load_w:
 load_h:
 			ptr = load_pointer(skb, k, 2, &tmp);
 			if (ptr != NULL) {
-				A = ntohs(*(u16 *)ptr);
+				A = ntohs(get_unaligned((u16 *)ptr));
 				continue;
 			}
 			break;

---

• Follow-Ups:
  • Re: [PATCH] unaligned access in sk_run_filter()
    • From: "David S. Miller" <[email protected]>

• Prev by Date: Re: Is notify_die being overloaded?
• Next by Date: 2.6.16.1 psmouse.c: TouchPad at isa0060/serio4/input0 lost sync at byte 1 and ACPI
• Previous by thread: want to randomly drop packets based on percent
• Next by thread: Re: [PATCH] unaligned access in sk_run_filter()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]