RE: [patch 1/3] acpi: dock driver

["Brown, Len" <len.brown@intel.com>]

Re: indenting & white-space

Please run the whole thing through the latest Lindent.
It will delete the white space.
It will do a couple of stupid things with indenting --
such as with MODULE_AUTHOR --
feel free to hand tweak those by hand.

Re: acpi_os_free()
Please call kfree() instead, that wrapper is intended
just for the ACPICA core and although it appears symmetric,
it really shouldn't be used outside drivers/acpi/*/*.c

Re: ACPI_FUNCTION_TRACE()/return_VALUE()
Don't feel compelled to include these idioms unless
you think they will really be useful.

Re: ACPI_FAILURE()
just use printk(KERN_whatever_level_you_like "...") here.

Re: ACPI_DEBUG_PRINT()
note that these appear only with CONFIG_ACPI_DEBUG
(along with tracing).  So if you want it to go away
in the production kernel, this is okay.  but if you want
it to ship in the production kernel, use printk().


> > +config ACPI_DOCK
> > +	tristate "Dock"
> > +	default y
> > +	help
> > +	  This driver adds support for ACPI controlled docking stations
> 
> It doesn't depend upon anything else?

What happens if the acpi_ibm driver's docking support is enabled at the
same time.
Perhaps that should depend on not this?

-Len
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/