Vadim Lobanov <[email protected]> wrote:
>
> I can put in a comment to explain what the code is doing, or if you
> think that the bitmasking itself is "yuk", then I can easily transform
> the code into an explicit "if () {}" block. :)
yes please.
> > Yuk. Sorry, no.
>
> Thank you for the review. The comments above are easy to address. Do you
> like the main concept behind the patch? Should I correct and resubmit?
I don't really understand it yet.
Yes, please resend and feel free to a) add comments in places where we can
help people to understand the code and b) convert any code which gets
touched to be coding-style-friendly. (I usually recommend that we do that
even if the surrounding code uses different conventions - eventually
everything will be fixed ;))
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
