Re: [RFD][PATCH] typhoon and core sample for folding away VLAN stuff

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ingo Oeser wrote:
Dave Dillow: Is this style clean enough to have it in your driver?
Though I'm not real fond of Denis's last patch, I think I prefer it's
style to this, solely because it removes more code when VLANs are
disabled -- you've left the spin_locks in, and have more #ifdefs.
Regardless, I remain opposed to this particular instance of bloat
busting. While both patches have improved in style, they remove a useful
feature and make the code less clean, for no net gain.
This kind of changes are important, because bloat creeps in byte by byte
of unused features. So I really appreciate your work here Denis.
On SMP FC4, typhoon.ko has a text size of 68330, so you need to cut 2794
bytes to see an actual difference in memory usage for a module. Non-SMP
it is 67741, so there you only need to cut 2205 bytes to get a win.
Every byte counts, except when it doesn't.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux