On Tue, 11 Apr 2006 13:38:09 +0200 (MEST) Jan Engelhardt <[email protected]> wrote: > > >@@ -352,6 +353,10 @@ static char *make_block_name(struct gend > > return NULL; > > strcpy(name, block_str); > > strcat(name, disk->disk_name); > >+ /* ewww... some of these buggers have / in name... */ > >+ s = strchr(name, '/'); > >+ if (s) > >+ *s = '!'; > > return name; > > } > > > > Can they have multiple '/'? If so, we need a while loop. The other place that fixes this (just 10 or so lines further on in this file) does not loop. Looking through the block devices, there is no obvious place that creates a name with more than one '/'. -- Cheers, Stephen Rothwell [email protected] http://www.canb.auug.org.au/~sfr/
Attachment:
signature.asc
Description: PGP signature
- References:
- [PATCH] Fix block device symlink name
- From: Stephen Rothwell <[email protected]>
- Re: [PATCH] Fix block device symlink name
- From: Jan Engelhardt <[email protected]>
- [PATCH] Fix block device symlink name
- Prev by Date: [git patches] kbuild fixes for 2.6.17-rc1
- Next by Date: [PATCH] x86_64 sparsemem does not need node_mem_map
- Previous by thread: Re: [PATCH] Fix block device symlink name
- Next by thread: [PATCH] deinline few large functions in inet6 code
- Index(es):
 |