On Mon, Apr 10, 2006 at 11:55:22AM +0200, Takashi Iwai wrote:
> > > This patch moves the EXPORT_SYMBOL's from
> > > > sound/pci/emu10k1/emu10k1_main.c to the files with the actual functions.
> > >
> > > What is the merit of this movement?
> >
> > 1) Documentation - it is obvious that the function/data is exported so
> > be a bit mroe careful when introducing changes
> > 2) Style. In 2.6 the preferred style is to put the EXPORT_SYMBOL on the
> > line following the closing } of the exported function.
> > 3) Keep changes local. If one removes a previously exported symbol less
> > files needs to be touched.
>
> I know the above for the new codes, yes. But my question is wheter do
> we get a good enough benifit by changing the existing code.
>
> I'm not against such an action but just wornder whether it's really
> needed. If yes, we should do it over the whole tree.
That has been done to a lot of existing code also.
In the 2.4 days it made sense to have them grouped due to build system
limitations - that is no longer the case with 2.6 so it is preferred to
do it correct.
Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
