Re: [PATCH rc1-mm 1/3] coredump: some code relocations

> This is a preparation for the next patch. No functional changes.
> Basically, this patch moves '->flags & SIGNAL_GROUP_EXIT' check
> into zap_threads(), and 'complete(vfork_done)' into coredump_wait
> outside of ->mmap_sem protected area.
> 
> Signed-off-by: Oleg Nesterov <[email protected]>

I don't see anything especially wrong with these reorganizations.  I'd
prefer if the commentary for the change indicated what about them was
required for the following patches.  Making zap_threads have a return value
does seem sort of random and obfuscatory, but that is a minor nit.


Thanks,
Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH rc1-mm 1/3] coredump: some code relocations
    • From: Oleg Nesterov <[email protected]>

• Prev by Date: Re: [PATCH rc1-mm 0/3] coredump: rfc
• Next by Date: Re: [PATCH rc1-mm 2/3] coredump: shutdown current process first
• Previous by thread: [PATCH rc1-mm 1/3] coredump: some code relocations
• Next by thread: Re: + git-klibc-mktemp-fix.patch added to -mm tree
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]