Sam Ravnborg <[email protected]> wrote:
> On Sat, Apr 08, 2006 at 12:05:54AM -0700, [email protected] wrote:
>> diff -puN usr/dash/mkbuiltins~git-klibc-mktemp-fix usr/dash/mkbuiltins
>> --- 25/usr/dash/mkbuiltins~git-klibc-mktemp-fix Sat Apr 8 14:51:11 2006
>> +++ 25-akpm/usr/dash/mkbuiltins Sat Apr 8 14:51:11 2006
>> - tempfile=mktemp
>> + tempfile="mktemp /tmp/tmp.XXXXXX"
>
> Shouldn't that be:
>> + tempfile="$(mktemp /tmp/tmp.XXXXXX)"
No. You should use tempfile="$(mktemp ${TMPDIR:-/tmp}/tmp.XXXXXX)"
(or mktemp -t, if it's portable enough)
Besides that, tmp.XXXXXX should be replayed using a better name.
</nitpick>
--
Ich danke GMX dafür, die Verwendung meiner Adressen mittels per SPF
verbreiteten Lügen zu sabotieren.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
