Re: [PATCH rc1-mm] de_thread: fix deadlockable process addition

[Oleg Nesterov <oleg@tv-sign.ru>]

On 04/09, Oleg Nesterov wrote:
>
> proc_task_readdir:
> 
> 	first_tid() returns old_leader
> 
> 	next_tid()  returns new_leader
> 	
> 						de_thread:
> 							old_leader->group_leader = new_leader;
> 
> 	
> 	next_rid()  returns old_leader again,
> 	because it is not thread_group_leader()
> 	anymore

I think something like this for next_tid() is sufficient:

	-	if (thread_group_leader(pos))
	+	if (pos->pid == pos->tgid)

We can also do the same change in first_tgid().

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/