Re: [PATCH rc1-mm] de_thread: fix deadlockable process addition

On 04/09, Oleg Nesterov wrote:
>
> proc_task_readdir:
> 
> 	first_tid() returns old_leader
> 
> 	next_tid()  returns new_leader
> 	
> 						de_thread:
> 							old_leader->group_leader = new_leader;
> 
> 	
> 	next_rid()  returns old_leader again,
> 	because it is not thread_group_leader()
> 	anymore

I think something like this for next_tid() is sufficient:

	-	if (thread_group_leader(pos))
	+	if (pos->pid == pos->tgid)

We can also do the same change in first_tgid().

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH rc1-mm] de_thread: fix deadlockable process addition
    • From: [email protected] (Eric W. Biederman)

• References:
  • [PATCH rc1-mm] de_thread: fix deadlockable process addition
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH rc1-mm] de_thread: fix deadlockable process addition
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH rc1-mm] de_thread: fix deadlockable process addition
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH rc1-mm] de_thread: fix deadlockable process addition
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH rc1-mm] de_thread: fix deadlockable process addition
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH rc1-mm] de_thread: fix deadlockable process addition
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH rc1-mm] de_thread: fix deadlockable process addition
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH rc1-mm] de_thread: fix deadlockable process addition
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH rc1-mm] de_thread: fix deadlockable process addition
    • From: Oleg Nesterov <[email protected]>

• Prev by Date: Re: [PATCH rc1-mm] de_thread: fix deadlockable process addition
• Next by Date: Re: Black box flight recorder for Linux
• Previous by thread: Re: [PATCH rc1-mm] de_thread: fix deadlockable process addition
• Next by thread: Re: [PATCH rc1-mm] de_thread: fix deadlockable process addition
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]