Re: [patch] represent-dirty__centisecs-as-jiffies-internally.patch comment fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Coywolf Qi Hunt wrote:
2006/3/25, [email protected] <[email protected]>:

From: Bart Samwel <[email protected]>

Make that the internal values for:

/proc/sys/vm/dirty_writeback_centisecs
/proc/sys/vm/dirty_expire_centisecs

are stored as jiffies instead of centiseconds.  Let the sysctl interface do
the conversions with full precision using clock_t_to_jiffies, instead of
doing overflow-sensitive on-the-fly conversions every time the values are
used.

diff -puN mm/page-writeback.c~represent-dirty__centisecs-as-jiffies-internally mm/page-writeback.c
--- devel/mm/page-writeback.c~represent-dirty__centisecs-as-jiffies-internally  2006-03-24 03:00:41.000000000 -0800
+++ devel-akpm/mm/page-writeback.c      2006-03-24 03:00:41.000000000 -0800
@@ -75,12 +75,12 @@ int vm_dirty_ratio = 40;
  * The interval between `kupdate'-style writebacks, in centiseconds
  * (hundredths of a second)

Bart,

You forgot to fix the comments. The attached patch fixes them.

Thanks, well spotted. I think the other patch already went into Linus' tree, I guess this should go in there as well?

Cheers,
Bart
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux