Re: PATCH 6/7] tpm: new 1.2 sysfs files - Updated patch

[Greg KH <greg@kroah.com>]

On Wed, Apr 05, 2006 at 02:48:24PM -0500, Kylene Jo Hall wrote:
> On Mon Apr 03, 2006 at 21:47:25 Greg KH wrote:
> <snip>
> > > +EXPORT_SYMBOL_GPL(tpm_show_state);
> > 
> > That is more than one value per file.  Please make unique files for the
> > different capabilities.  As it stands the file doesn't make too much
> > sense for someone reading it and not understanding that each line is a
> > different portion of the state.
> > 
> > thanks,
> > 
> > greg k-h
> tpm_show_state removed in this patch in favor of separate files.

Thanks for changing this, looks much better now.

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/