[patch] serial: fix UART_BUG_TXEN test

  Hi,

There is a bug in the UART_BUG_TXEN test: It gives false positives in
case the UART_IER_THRI bit is set.  Fixed by explicitly clearing the
UART_IER register first.

It may trigger with an active serial console as serial console writes
set the UART_IER_THRI bit.

cheers,

  Gerd

Signed-off-by: Gerd Hoffmann <[email protected]>
--- linux-2.6.16/drivers/serial/8250.c.serial	2006-04-05 12:04:31.000000000 +0200
+++ linux-2.6.16/drivers/serial/8250.c	2006-04-05 12:04:49.000000000 +0200
@@ -1712,6 +1712,7 @@
 	 * Do a quick test to see if we receive an
 	 * interrupt when we enable the TX irq.
 	 */
+	serial_outp(up, UART_IER, 0);
 	serial_outp(up, UART_IER, UART_IER_THRI);
 	lsr = serial_in(up, UART_LSR);
 	iir = serial_in(up, UART_IIR);

---

• Follow-Ups:
  • Re: [patch] serial: fix UART_BUG_TXEN test
    • From: Russell King <[email protected]>

• Prev by Date: [PATCH] Keys: Improve usage of memory barriers and remove IRQ disablement [try #2]
• Next by Date: Re: [PATCH] Doc; fix mtrr userspace programs to build cleanly
• Previous by thread: [PATCH] Keys: Improve usage of memory barriers and remove IRQ disablement [try #2]
• Next by thread: Re: [patch] serial: fix UART_BUG_TXEN test
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]