Adrian Bunk wrote: > This patch contains the following cleanups: > - makethe needlessly global gigaset_get_cs_by_tty() static > - remove the unused EXPORT_SYMBOL_GPL(gigaset_debugdrivers) Thanks for catching these. > Signed-off-by: Adrian Bunk <[email protected]> Acked-by: Tilman Schmidt <[email protected]> > > --- > > drivers/isdn/gigaset/common.c | 17 ++++++++--------- > drivers/isdn/gigaset/gigaset.h | 1 - > 2 files changed, 8 insertions(+), 10 deletions(-) > > --- linux-2.6.16-mm2-full/drivers/isdn/gigaset/gigaset.h.old 2006-04-04 00:15:36.000000000 +0200 > +++ linux-2.6.16-mm2-full/drivers/isdn/gigaset/gigaset.h 2006-04-04 00:15:42.000000000 +0200 > @@ -754,7 +754,6 @@ > /* Deallocate driver structure. */ > void gigaset_freedriver(struct gigaset_driver *drv); > void gigaset_debugdrivers(void); > -struct cardstate *gigaset_get_cs_by_minor(unsigned minor); > struct cardstate *gigaset_get_cs_by_tty(struct tty_struct *tty); > struct cardstate *gigaset_get_cs_by_id(int id); > > --- linux-2.6.16-mm2-full/drivers/isdn/gigaset/common.c.old 2006-04-04 00:06:34.000000000 +0200 > +++ linux-2.6.16-mm2-full/drivers/isdn/gigaset/common.c 2006-04-04 00:16:45.000000000 +0200 > @@ -962,16 +962,8 @@ > } > spin_unlock_irqrestore(&driver_lock, flags); > } > -EXPORT_SYMBOL_GPL(gigaset_debugdrivers); > > -struct cardstate *gigaset_get_cs_by_tty(struct tty_struct *tty) > -{ > - if (tty->index < 0 || tty->index >= tty->driver->num) > - return NULL; > - return gigaset_get_cs_by_minor(tty->index + tty->driver->minor_start); > -} > - > -struct cardstate *gigaset_get_cs_by_minor(unsigned minor) > +static struct cardstate *gigaset_get_cs_by_minor(unsigned minor) > { > unsigned long flags; > static struct cardstate *ret = NULL; > @@ -994,6 +986,13 @@ > return ret; > } > > +struct cardstate *gigaset_get_cs_by_tty(struct tty_struct *tty) > +{ > + if (tty->index < 0 || tty->index >= tty->driver->num) > + return NULL; > + return gigaset_get_cs_by_minor(tty->index + tty->driver->minor_start); > +} > + > void gigaset_freedriver(struct gigaset_driver *drv) > { > unsigned long flags; > -- Tilman Schmidt E-Mail: [email protected] Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
Attachment:
signature.asc
Description: OpenPGP digital signature
- References:
- [2.6 patch] drivers/isdn/gigaset/common.c: small cleanups
- From: Adrian Bunk <[email protected]>
- [2.6 patch] drivers/isdn/gigaset/common.c: small cleanups
- Prev by Date: Re: + isdn4linux-siemens-gigaset-drivers-logging-usage.patch added to -mm tree
- Next by Date: Re: [2.6 patch] isdn/gigaset/common.c: fix a memory leak
- Previous by thread: [2.6 patch] drivers/isdn/gigaset/common.c: small cleanups
- Next by thread: [2.6 patch] remove the bouncing email address of David Campbell
- Index(es):
 |