Re: [patch 2/3] mm: speculative get_page

Looks like the NoNewRefs flag is mostly == 
spin_is_locked(mapping->tree_lock)? Would it not be better to check the 
tree_lock?


> --- linux-2.6.orig/mm/migrate.c
> +++ linux-2.6/mm/migrate.c
>  
> +	SetPageNoNewRefs(page);
>  	write_lock_irq(&mapping->tree_lock);

A dream come true! If this is really working as it sounds then we can 
move the SetPageNoNewRefs up and avoid the final check under 
mapping->tree_lock. Then keep SetPageNoNewRefs until the page has been 
copied. It would basically play the same role as locking the page.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 2/3] mm: speculative get_page
    • From: Nick Piggin <[email protected]>

• References:
  • [patch 0/3] lockless pagecache
    • From: Nick Piggin <[email protected]>
  • [patch 2/3] mm: speculative get_page
    • From: Nick Piggin <[email protected]>

• Prev by Date: [PATCH RFC/testing] Upgrade the zlib_inflate library code to a recent version
• Next by Date: Re: [patch 2/3] mm: speculative get_page
• Previous by thread: Re: [patch 2/3] mm: speculative get_page
• Next by thread: Re: [patch 2/3] mm: speculative get_page
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]