Re: [linux-usb-devel] compile error when building multiple EHCI host controllers as modules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Apr 3, 2006, at 9:48 PM, David Brownell wrote:

On Friday 24 March 2006 12:32 pm, Kumar Gala wrote:
The issue I have this is that it makes two (or more) things that were
independent now dependent.  What about just moving the module_init/
exit() functions into files that are built separately. For the ehci-
fsl case it was trivial, need to look at ehci-pci case.

Ok, my idea required exporting things I didn't really want to export, so
what about something like this or where you thinking of some more
sophisticated?

If this is good, I'll do the same for ohci.

How about this one instead? It requires fewer per-SOC hacks in generic code when adding a new SOC. And it also removes a platform device naming goof for your mpc83xx support ... that's a case where you should just let
the platform device IDs distinguish things.

Let me test this patch out. I'm ok with the changes for handling both PCI and platform driver. However, I need to take a look at the renaming of the fsl driver. The "dr" device supports device and OTG modes. I'm concerned about how we distinguish that in the future.

(also, we need to fixup arch/powerpc/sysdev/fsl_soc.c)

- k


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux