potential null dereference in splice code.

We can get to out: with a NULL page, which we probably
don't want to be calling page_cache_release() on.

Signed-off-by: Dave Jones <[email protected]>

--- linux-2.6.16.noarch/fs/splice.c~	2006-04-03 18:47:40.000000000 -0500
+++ linux-2.6.16.noarch/fs/splice.c	2006-04-03 18:50:06.000000000 -0500
@@ -445,7 +445,7 @@ find_page:
 		ret = -ENOMEM;
 		page = find_or_create_page(mapping, index, gfp_mask);
 		if (!page)
-			goto out;
+			goto out_nomem;
 
 		/*
 		 * If the page is uptodate, it is also locked. If it isn't
@@ -507,6 +507,7 @@ out:
 		page_cache_release(page);
 		unlock_page(page);
 	}
+out_nomem:
 	buf->ops->unmap(info, buf);
 	return ret;
 }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: potential null dereference in splice code.
    • From: Jens Axboe <[email protected]>

• Prev by Date: Re: [PATCH] Add a /proc/self/exedir link
• Next by Date: [PATCH 0/13] isdn4linux: Siemens Gigaset drivers update
• Previous by thread: [PATCH] Add a /proc/self/exedir link
• Next by thread: Re: potential null dereference in splice code.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]