On Monday 03 April 2006 05:50 pm, Russell King wrote:
> On Mon, Apr 03, 2006 at 05:20:02PM +0900, Hyok S. Choi wrote:
>
> Thanks for looking at the previous points, this driver is much better.
> However, there's still some bits which could be even better.
Okay.
> > +/* use ttyJ0(128) */
> > +#define SERIAL_DCC_NAME "ttyJ"
> > +#define SERIAL_DCC_MINOR (64 + 64)
> > +#endif
> > +#define SERIAL_DCC_MAJOR TTY_MAJOR
>
> Why not just get a proper legal allocation from LANANA ?
I've just requested for an allocation of minor # for major# 204.
> > +static inline u32
> > +__dcc_getstatus(void)
>
> Column space is not at a premium.
>
> static inline u32 __dcc_getstatus(void)
>
> will do just as well. Does the double underscore here serve any purpose?
__* naming is used for assembly based primitive functions, that have dependencies
on JTAG1 protocol. Actually, I'd like to extend to support JTAG4 in a mean while.
> > +{
> > + u32 __ret;
>
> The double underscore here serves no purpose.
got it.
> > +static inline void
> > +__dcc_putchar(char c)
> > +{
> > + asm("mcr p14, 0, %0, c1, c0 @ write a char"
> > + : /* no output register */
> > + : "r" (c));
> > +}
> > +
> > +static void
> > +dcc_putchar(struct uart_port *port, int ch)
> > +{
> > + while (__dcc_getstatus() & DCC_STATUS_TX)
> > + cpu_relax();
> > + __dcc_putchar((char)(ch & 0xFF));
>
> Since this is the only place __dcc_putchar is used, might be an idea to
> move it into this function?
You're right.
But, as I mentioned above, I wanted to split JTAG1 dependencies.
If you strongly want to move into there, I will.
> > +}
> > +
> > +static inline void
> > +xmit_string(struct uart_port *port, char *p, int len)
> > +{
> > + for ( ; len; len--, p++)
> > + dcc_putchar(port, *p);
> > +}
> > +
> > +static inline void
> > +dcc_transmit_buffer(struct uart_port *port)
> > +{
> > + struct circ_buf *xmit = &port->info->xmit;
> > + int pendings = uart_circ_chars_pending(xmit);
> > +
> > + if(pendings + xmit->tail > UART_XMIT_SIZE)
> > + {
>
> Mixture of bracing styles, and there should be a space between if and (.
> if (pendings + xmit->tail > UART_XMIT_SIZE) {
>
Fixed.
> > + /* for JTAG 1 protocol, incount is always 1. */
> > + ch = __dcc_getchar();
> > +
> > + if (tty) {
> > + tty_insert_flip_char(tty, ch, TTY_NORMAL);
> > + port->icount.rx++;
> > + tty_flip_buffer_push(tty);
> > + }
> > + }
> > +}
> > +
> > +static inline void
> > +dcc_overrun_chars(struct uart_port *port)
> > +{
> > + port->icount.overrun++;
> > +}
>
> This doesn't seem to be used anywhere.
Removed.
> > +static int
> > +dcc_startup(struct uart_port *port)
> > +{
> > +#ifdef DCC_IRQ_USED /* real IRQ used */
> > + int retval;
> > +
> > + /* Allocate the IRQ */
> > + retval = request_irq(port->irq, dcc_int, SA_INTERRUPT,
> > + "serial_dcc", port);
> > + if (retval)
> > + return retval;
> > +#else /* emulation */
> > + /* Initialize the work, and shcedule it. */
> > + INIT_WORK(&dcc_poll_task, dcc_poll, port);
> > + spin_lock(&port->lock);
> > + if (dcc_poll_state != DCC_POLL_RUN)
> > + dcc_poll_state = DCC_POLL_RUN;
> > + schedule_delayed_work(&dcc_poll_task, 1);
> > + spin_unlock(&port->lock);
>
> Hmm, this looks over complex:
>
> if (dcc_poll_state != DCC_POLL_RUN)
> dcc_poll_state = DCC_POLL_RUN;
>
> and unnecessary (see dcc_shutdown comments.)
>
> Secondly, wouldn't it be better to have INIT_WORK() in the driver
> initialisation?
>
> > +#endif
> > +
> > + return 0;
> > +}
> > +
> > +static void
> > +dcc_shutdown(struct uart_port *port)
> > +{
> > +#ifdef DCC_IRQ_USED /* real IRQ used */
> > + free_irq(port->irq, port);
> > +#else
> > + spin_lock(&port->lock);
> > + dcc_poll_state = DCC_POLL_STOP;
> > + spin_unlock(&port->lock);
>
> Rather than having this dcc_poll_state, wouldn't the use of:
>
> cancel_rearming_delayed_work(&dcc_poll_task);
>
> suffice?
Good. Hmm, the lock protections are still needed.
Otherwise, it may have some race condition.
--
Hyok
ARM Linux 2.6 MPU/noMMU Project http://opensrc.sec.samsung.com/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
