Re: [PATCH 1/1] POWERPC: Fix ppc32 compile with gcc+SSP in 2.6.16

[John Mylchreest <johnm@gentoo.org>]

On Sun, Apr 02, 2006 at 03:15:38PM +0200, Arjan van de Ven <arjan@infradead.org> wrote:
> 
> > Going from that, I can push a patch for gcc upstream to remove the
> > __KERNEL__ dep, but gcc4.1 ships with ssp by standard, and the semantics
> > between the IBM patch for SSP applied to gcc-3 and ggc-4 have changed.
> > 
> > -fno-stack-protector would work for gcc4, but for gcc3 it could still be
> 
> since this is a thing you have to turn on to get it, not off to not get
> it, I think you're missing something big here ;)
> 
> > patially enabled, and requires -fno-stack-protector-all. Mind If I ask
> > whats incorrect about defining __KERNEL__ for the bootcflags?
> 
> it's silly and it's a non-standard gcc ... better get the gcc fixed to
> at least have the upstream protocol of having to turn it on not off..

It gets turned on elsewhere (gcc spec), but principle for me is that if its
enabled it still leaks and breaks this code. At the moment (following
from existing patches you put to this list) this mix will break until we
get stack-protector ported.

-- 
Role:            Gentoo Linux Kernel Lead
Gentoo Linux:    http://www.gentoo.org
Public Key:      gpg --recv-keys 9C745515
Key fingerprint: A0AF F3C8 D699 A05A EC5C  24F7 95AA 241D 9C74 5515

Attachment: pgpG4bApmlVKY.pgp
Description: PGP signature