Zoltan Menyhart wrote:
However, I do not think your implementation would be efficient due to
selecting the ordering mode at run time:
+ switch (mode) {
+ case MODE_NONE :
+ case MODE_ACQUIRE :
+ return cmpxchg_acq(m, old, new);
+ case MODE_FENCE :
+ smp_mb();
+ /* Fall through */
+ case MODE_RELEASE :
+ return cmpxchg_rel(m, old, new);
BTW. Isn't MODE_FENCE wrong? Seems like a read or write could be moved
above cmpxchg_rel?
I think you need rel+acq rather than acq+rel (if I'm right, then the
same goes for your earlier bitops patches, btw).
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
