Re: [Patch 7/8] proc interface for block I/O delays

[Andrew Morton <akpm@osdl.org>]

Shailabh Nagar <nagar@watson.ibm.com> wrote:
>
> delayacct-procfs.patch
> 
> Export I/O delays seen by a task through /proc/<tgid>/stats
> for use in top etc.
> 
> Note that delays for I/O done for swapping in pages (swapin I/O) is
> clubbed together with all other I/O here (this is not the
> case in the netlink interface where the swapin I/O is kept distinct)
> 
> ...
>
> +
> +unsigned long long __delayacct_blkio_ticks(struct task_struct *tsk)

Why unsigned long long here, rather than __u64?

> +{
> +	unsigned long long ret;
> +
> +	if (!tsk->delays)
> +		return 0;

delayacct_blkio_ticks() already checked that.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/