Re: [PATCH 2.6.16] sata_mv.c :: three bug fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Aloni <[email protected]>
Subject: Re: [PATCH 2.6.16] sata_mv.c :: three bug fixes
From: Mark Lord <[email protected]>
Date: Wed, 29 Mar 2006 12:37:22 -0500
Cc: Mark Lord <[email protected]>, IDE/ATA development list <[email protected]>, Linux Kernel <[email protected]>, Jens Axboe <[email protected]>, Jeff Garzik <[email protected]>, [email protected], [email protected]
In-reply-to: <20060329170628.GA25640@localdomain>
References: <[email protected]> <20060329170628.GA25640@localdomain>
Sender: [email protected]
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20060305 SeaMonkey/1.1a

Dan Aloni wrote:

The original code checks ap for NULL, are you sure it is safe to
remove this?


"ap" is used above in the same function, long before the check for NULL,
so the checks lower down are worthless.

Cheers

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [PATCH 2.6.16] sata_mv.c :: three bug fixes
  - From: Mark Lord <[email protected]>
- Re: [PATCH 2.6.16] sata_mv.c :: three bug fixes
  - From: Dan Aloni <[email protected]>

Prev by Date: Re: 11 minute RTC update (was Re: Remove RTC UIP)
Next by Date: [git pull] InfiniBand updates for 2.6.17
Previous by thread: Re: [PATCH 2.6.16] sata_mv.c :: three bug fixes
Next by thread: Re: [PATCH 2.6.16] sata_mv.c :: three bug fixes
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]

Powered by Linux