Re: [PATCH -mm 0/4] LED Updates

[Richard Purdie <rpurdie@rpsys.net>]

On Tue, 2006-03-28 at 16:23 -0800, Andrew Morton wrote:
> Richard Purdie <rpurdie@rpsys.net> wrote:
> >
> > ...
> >
> > Also add some missing externs.
> >
> > ... 
> >  
> >  /* Registration functions for complex triggers */
> > -int led_trigger_register(struct led_trigger *trigger);
> > -void led_trigger_unregister(struct led_trigger *trigger);
> > +extern int led_trigger_register(struct led_trigger *trigger);
> > +extern void led_trigger_unregister(struct led_trigger *trigger);
> 
> Well.  The externs weren't "missing".  They were "unnecessary".  I don't
> know why we do this really - it doesn't communicate any information.  Oh
> well.

Half of the leds header had them, half of it didn't. I looked at some
other kernel headers and saw the were present so presumed they were
needed for some reason. Looks like I changed the wrong half... :-/

Richard

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/