On Mon, Mar 27, 2006 at 07:11:11PM +0200, Jean Delvare wrote:
> Hi Mark,
>
> > This patch does some cleanup to the m41t00 i2c/rtc driver including:
> > - use BCD2BIN/BIN2BCD instead of BCD_TO_BIN/BIN_TO_BCD
> > - use strlcpy instead of strncpy
> > - some whitespace cleanup
>
> Looks overall good, except:
>
> > @@ -214,6 +208,7 @@ m41t00_detach(struct i2c_client *client)
> >
> > static struct i2c_driver m41t00_driver = {
> > .driver = {
> > + .owner = THIS_MODULE,
> > .name = M41T00_DRV_NAME,
> > },
> > .id = I2C_DRIVERID_STM41T00,
>
> i2c_add_driver sets the owner for you, so it was omitted here on
> purpose.
>
> I'll drop that change before pushing the patch to Greg, no need to
> resend.
Hang on for a bit, Jean. I'm making a new set of patches with yours and
Andrew's comments addressed. Will be out shortly.
Mark
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
