Re: [PATCH] mm: swsusp shrink_all_memory tweaks

Hi!

> > swsusp_shrink_memory() is still wrong, because it will always fail for
> > image_size = 0.  My bad, sorry.
> >
> > The appended patch (on top of yours) should fix that (hope I did it right
> > this time).
> 
> Well I discovered that if all the necessary memory is freed in one call to
>  shrink_all_memory we don't get the nice updating printout from
>  swsusp_shrink_memory telling us we're making progress. So instead of
>  modifying the function to call shrink_all_memory with the full amount (and
>  since we've botched swsusp_shrink_memory a few times between us), we should
>  limit it to a max of SHRINK_BITEs instead.
> 
>  This patch is fine standalone.
> 
>  Rafael, Pavel what do you think of this one? 

Looks good to me (but I'm not a mm expert).
									Pavel

-- 
Picture of sleeping (Linux) penguin wanted...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH][1/3] mm: swsusp shrink_all_memory tweaks
    • From: Con Kolivas <[email protected]>
  • Re: [PATCH][1/3] mm: swsusp shrink_all_memory tweaks
    • From: Con Kolivas <[email protected]>
  • Re: [PATCH][1/3] mm: swsusp shrink_all_memory tweaks
    • From: "Rafael J. Wysocki" <[email protected]>
  • [PATCH] mm: swsusp shrink_all_memory tweaks
    • From: Con Kolivas <[email protected]>

• Prev by Date: Re: [PATCH] cleanup for net/tipc/name_distr.c::tipc_named_node_up()
• Next by Date: Re: [PATCH 2.6.15] Adding kernel-level identd dispatcher
• Previous by thread: Re: [PATCH] mm: swsusp shrink_all_memory tweaks
• Next by thread: [PATCH][2/3] mm: swap prefetch aggressive mode
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]