Hi Andi. On Friday 24 March 2006 21:36, Andi Kleen wrote: > On Friday 24 March 2006 12:14, Jean Delvare wrote: > > Hi Nigel, Andi, all, > > > > > It looks to me like the above commit from Andi causes a compilation > > > failure on x86_64, because it makes pci_mmcfg_init non static: > > > > > > arch/x86_64/pci/mmconfig.c:152: error: conflicting types for > > > ‘pci_mmcfg_init’ arch/i386/pci/pci.h:85: error: previous declaration of > > > ‘pci_mmcfg_init’ was here > > > make[1]: *** [arch/x86_64/pci/mmconfig.o] Error 1 > > > make: *** [arch/x86_64/pci] Error 2 > > > > I just hit the same compilation failure. Here's a fix which works for > > me. > > This was my mistake. I fixed the problem in the wrong patch. And then > Greg submitted only the one patch. I think Andrew fixed it up by > submitting the other (unrelated) patch which fixes this too. Thanks for the reply. It's not in Linus' tree yet, so I think the Andrew might still need some encouragement to merge it :) Regards, Nigel
Attachment:
pgpY10kQDfXV9.pgp
Description: PGP signature
- References:
- 92c05fc1a32e5ccef5e0e8201f32dcdab041524c breaks x86_64 compile.
- From: Nigel Cunningham <[email protected]>
- Re: 92c05fc1a32e5ccef5e0e8201f32dcdab041524c breaks x86_64 compile.
- From: Jean Delvare <[email protected]>
- Re: 92c05fc1a32e5ccef5e0e8201f32dcdab041524c breaks x86_64 compile.
- From: Andi Kleen <[email protected]>
- 92c05fc1a32e5ccef5e0e8201f32dcdab041524c breaks x86_64 compile.
- Prev by Date: [PATCH] Fix x86_64 compilation breakage caused by 92c05fc1a32e5ccef5e0e8201f32dcdab041524c
- Next by Date: Re: kernel BUG at fs/direct-io.c:916!
- Previous by thread: Re: 92c05fc1a32e5ccef5e0e8201f32dcdab041524c breaks x86_64 compile.
- Next by thread: Re: 92c05fc1a32e5ccef5e0e8201f32dcdab041524c breaks x86_64 compile.
- Index(es):
 |