Re: bus_add_device() losing an error return from the probe() method

Andrew Morton wrote:

Looks sane, but please don't sprinkle `return' statements all over a function in this manner.

I actually prefer the multiple returns. You then don't have to "visually scroll down" to the label to see what would happen when reading the code. Even when there's common code before the return, I've never seen GCC not optimise that to the goto form itself. You obviously the boss though.

It's a little surprising that this function returns "OK" if bus==NULL.

Note that sysfs_create_link() can fail too.  This was one optimistic
function.

I assume that Greg hasn't commented yet since he's busy rewriting it all, so that'll be okay :-)

Rene.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • bus_add_device() losing an error return from the probe() method
    • From: Rene Herman <[email protected]>
  • Re: bus_add_device() losing an error return from the probe() method
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: Readahead value 128K? (was Re: Drastic Slowdown of 'fseek()'
• Next by Date: Re: [PATCH] Move SG_GET_SCSI_ID from sg to scsi
• Previous by thread: Re: bus_add_device() losing an error return from the probe() method
• Next by thread: Re: bus_add_device() losing an error return from the probe() method
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]