Re: [patch 04/10] PI-futex: scheduler support for PI

[Andrew Morton <akpm@osdl.org>]

Ingo Molnar <mingo@elte.hu> wrote:
>
> From: Ingo Molnar <mingo@elte.hu>
> 
> add framework to boost/unboost the priority of RT tasks.
> 
> This consists of:
> 
>  - caching the 'normal' priority in ->normal_prio
>  - providing a functions to set/get the priority of the task
>  - make sched_setscheduler() aware of boosting
> 
> ...
>
> +#ifdef CONFIG_RT_MUTEXES
> +
> +/*
> + * rt_mutex_setprio - set the current priority of a task
> + * @p: task
> + * @prio: prio value (kernel-internal form)
> + *
> + * This function changes the 'effective' priority of a task. It does
> + * not touch ->normal_prio like __setscheduler().
> + *
> + * Used by the rt_mutex code to implement priority inheritance logic.
> + */
> +void rt_mutex_setprio(task_t *p, int prio)
> +{

This function is not really rt-mutex-related at all, is it?  It's just a
piece of new scheduler functionality which various things might use.

If so, it should be named something non-mutexy and should be under a
different CONFIG_option which CONFIG_RT_MUTEXES selects.

Of course, we can do all that later on, if/when something else needs this
facility.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/