Re: SMP busted on non-cpu-hotplug systems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"David S. Miller" <[email protected]> wrote:
>
> 
> I just noticed this on sparc64, as I lost 31 cpus on my
> Niagara box due to it :)
> 
> boot_cpu_init() sets the boot processor ID in cpu_present_map.
> 
> But fixup_cpu_present_map() will only populate the cpu_present_map if
> it is empty, which it won't be because of what boot_cpu_init() just
> did.

oops.  I guess most architectures set cpu_present_map while bringing up the
APs.

I think it'd be cleanest to require that the arch do that -
fixup_cpu_present_map() looks like a bit of a hack.

I guess if we want to perpetuate fixup_cpu_present_map() then we should
teach it to ignore the boot cpu.   (cpus_weight(&cpu_present_map) == 1)
would do that.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux