On Fri, 2006-24-03 at 09:11 -0500, jamal wrote: > Look at using proper macros instead of hard coding like you did. > grep for something like RTA_SPACE and perhaps send a patch to make it > generic for netlink.h > actually Thomas already has this in netlink.h Look at using things like: nla_attr_size() make sure padding is taken care of etc (read: use the right macros). cheers, jamal - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- References:
- [Patch 0/9] Per-task delay accounting
- From: Shailabh Nagar <nagar@watson.ibm.com>
- [Patch 9/9] Generic netlink interface for delay accounting
- From: Shailabh Nagar <nagar@watson.ibm.com>
- Re: [Patch 9/9] Generic netlink interface for delay accounting
- From: Matt Helsley <matthltc@us.ibm.com>
- Re: [Patch 9/9] Generic netlink interface for delay accounting
- From: jamal <hadi@cyberus.ca>
- [RFC][UPDATED PATCH 2.6.16] [Patch 9/9] Generic netlink interface for delay accounting
- From: Balbir Singh <balbir@in.ibm.com>
- Re: [RFC][UPDATED PATCH 2.6.16] [Patch 9/9] Generic netlink interface for delay accounting
- From: jamal <hadi@cyberus.ca>
- Re: [RFC][UPDATED PATCH 2.6.16] [Patch 9/9] Generic netlink interface for delay accounting
- From: Balbir Singh <balbir@in.ibm.com>
- Re: [RFC][UPDATED PATCH 2.6.16] [Patch 9/9] Generic netlink interface for delay accounting
- From: jamal <hadi@cyberus.ca>
- [Patch 0/9] Per-task delay accounting
- Prev by Date: Re: Connector: Filesystem Events Connector v3
- Next by Date: Re: Connector: Filesystem Events Connector v3
- Previous by thread: Re: [RFC][UPDATED PATCH 2.6.16] [Patch 9/9] Generic netlink interface for delay accounting
- Next by thread: Re: [RFC][UPDATED PATCH 2.6.16] [Patch 9/9] Generic netlink interface for delay accounting
- Index(es):
 |