RE: [PATCH] Clean up magic numbers in i2c_parport.h

> Beeuh. These macros don't really help. They actually make the lines
longer! I'm not taking this change, sorry.

If I kill off the macros but continue to use C99 structure initializers,
which is I believe is the proper kernel coding style today, the lines are
going to get even longer.  Is that OK?

Or are you asking for the patch w/o macros and w/o C99 structure
initializers?

I can/will do either.  Just let me know what is acceptable a priori.

-ch

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Clean up magic numbers in i2c_parport.h
    • From: Jean Delvare <[email protected]>

• References:
  • Re: [PATCH] Clean up magic numbers in i2c_parport.h
    • From: Jean Delvare <[email protected]>

• Prev by Date: [PATCH 3 of 18] ipath - copy and send routines for sending an skb
• Next by Date: [PATCH 12 of 18] ipath - infiniband header files
• Previous by thread: Re: [PATCH] Clean up magic numbers in i2c_parport.h
• Next by thread: Re: [PATCH] Clean up magic numbers in i2c_parport.h
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]