Re: [PATCH] Try 3, Fix release function in IPMI device model

[Arjan van de Ven <arjan@infradead.org>]

On Wed, 2006-03-22 at 17:19 -0600, Corey Minyard wrote:
> I didn't get any comments on this, so I assume it is correct.
> I fixed the spelling of Arjan's name (profuse apologies) in
> this version, but otherwise it is the same.
> 
> I'm sorry to cause so much trouble with this.
> 
> -Corey
> 
> 
> 
> Arjan van de Ven pointed out that the changeover to the driver model
> in the IPMI driver had some bugs in it dealing with the release
> function and cleanup.  Then Russell King pointed out that you can't
> put release functions in the same module as the unregistering code.
> 
> This patch fixes those problems and also adds a semaphore around the
> BMC functions and converts the BMC counter to a kref, which I meant to
> do earlier, but didn't write down :(.


please use a mutex not a semaphore... semaphores for mutex code are
deprecated

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/