Re: [Patch] Possible NULL pointer dereference in fs/configfs/dir.c

On Thu, Mar 23, 2006 at 12:36:54AM +0100, Eric Sesterhenn wrote:
> I would then propose the following patch, so the check can be
> removed for people who like small kernels. I dont think gcc notices
> that all callers use non-NULL values and optimizes it away.
> 
> -	if (group && group->default_groups) {
> +	BUG_ON(!group);		/* group == NULL is not allowed */
> +	
> +	if (group->default_groups) {

	This is pretty much what I meant.  Thanks.

Joel
-- 

Life's Little Instruction Book #3

	"Watch a sunrise at least once a year."

Joel Becker
Principal Software Developer
Oracle
E-mail: [email protected]
Phone: (650) 506-8127
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [Patch] Possible NULL pointer dereference in fs/configfs/dir.c
    • From: Eric Sesterhenn <[email protected]>
  • Re: [Patch] Possible NULL pointer dereference in fs/configfs/dir.c
    • From: Joel Becker <[email protected]>
  • Re: [Patch] Possible NULL pointer dereference in fs/configfs/dir.c
    • From: Eric Sesterhenn <[email protected]>

• Prev by Date: cpu scheduler merge plans
• Next by Date: Re: [RFC, PATCH 10/24] i386 Vmi descriptor changes
• Previous by thread: Re: [Patch] Possible NULL pointer dereference in fs/configfs/dir.c
• Next by thread: Re: [Patch] Possible NULL pointer dereference in fs/configfs/dir.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]