Re: [PATCH] Try 2, Fix release function in IPMI device model

On 3/22/06, Corey Minyard <[email protected]> wrote:
>
>  struct bmc_device
>  {
> -       struct platform_device dev;
> +       struct platform_device *dev;
>        struct ipmi_device_id  id;
>        unsigned char          guid[16];
>        int                    guid_set;
> -       int                    interfaces;
> +
> +       struct kref            refcount;
>

Hi,

I am confused as to why you need kref here. Just unregister/kfree
memory occupied by your device structure after doing
platform_device_unregister and that's it. platform code won't
reference your memory and your attribute code should not be called
from module exit code so everything shoudl be fine.

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Try 2, Fix release function in IPMI device model
    • From: Corey Minyard <[email protected]>

• References:
  • [PATCH] Try 2, Fix release function in IPMI device model
    • From: Corey Minyard <[email protected]>

• Prev by Date: Re: libata ignores non-dma disks?
• Next by Date: [PATCH] driver core: driver_bind attribute returns incorrect value
• Previous by thread: Re: [PATCH] Try 2, Fix release function in IPMI device model
• Next by thread: Re: [PATCH] Try 2, Fix release function in IPMI device model
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]