Re: [PATCH 2/2] Add full sysfs support to the IPMI driver

On Tue, 2006-03-21 at 16:13 -0600, Corey Minyard wrote:


> +static void ipmi_bmc_release(struct device *dev)
> +{
> +	printk(KERN_DEBUG "ipmi_bmc release\n");
> +}


eehhhh NO.
Please read the many comments and documentations about why a release
function is NOT allowed to be empty. In fact the kernel warned you about
that, didn't it? 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 2/2] Add full sysfs support to the IPMI driver
    • From: Greg KH <[email protected]>

• References:
  • [PATCH 2/2] Add full sysfs support to the IPMI driver
    • From: Corey Minyard <[email protected]>

• Prev by Date: Re: [PATCH] 2.6.xx: sata_mv: another critical fix
• Next by Date: Re: [PATCH] hpet header sanitization
• Previous by thread: [PATCH 2/2] Add full sysfs support to the IPMI driver
• Next by thread: Re: [PATCH 2/2] Add full sysfs support to the IPMI driver
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]