Olivier Galibert wrote:
> On Mon, Mar 20, 2006 at 02:00:38PM -0800, Greg Kroah-Hartman wrote:
>
>>platform_get_irq*() cannot return 0 on error as 0 is a valid IRQ on some
>>platforms, return -ENXIO instead.
>
>
> 0 is NO_IRQ, and can not be a valid IRQ number, ever. A
> platform_get_irq*() returning 0 as a valid irq is buggy.
>
> Check http://lkml.org/lkml/2005/11/21/211
Regardless, it does make sense to make these functions to return a -ve
error code as is standard.
David Vrabel
--
David Vrabel, Design Engineer
Arcom, Clifton Road Tel: +44 (0)1223 411200 ext. 3233
Cambridge CB1 7EA, UK Web: http://www.arcom.com/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
