Re: [PATCH 02/23] kobject: fix build error if CONFIG_SYSFS=n

Hi Greg,

Moving them inside CONFIG_HOTPLUG && CONFIG_NET will break
CONFIG_NET=n build, because kernel/ksysfs.c will use them
#ifdef CONFIG_HOTPLUG.

Greg Kroah-Hartman wrote:

Moving uevent_seqnum and uevent_helper to kobject_uevent.c
because they are used even if CONFIG_SYSFS=n
while kernel/ksysfs.c is built only if CONFIG_SYSFS=y,

...

diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c
index 086a0c6..982226d 100644
--- a/lib/kobject_uevent.c
+++ b/lib/kobject_uevent.c
@@ -26,6 +26,8 @@
 #define NUM_ENVP	32	/* number of env pointers */

#if defined(CONFIG_HOTPLUG) && defined(CONFIG_NET)

+u64 uevent_seqnum;
+char uevent_helper[UEVENT_HELPER_PATH_LEN] = "/sbin/hotplug";
 static DEFINE_SPINLOCK(sequence_lock);
 static struct sock *uevent_sock;

Thanks,
--
Jun'ichi Nomura, NEC Solutions (America), Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 02/23] kobject: fix build error if CONFIG_SYSFS=n
    • From: Greg Kroah-Hartman <[email protected]>

• Prev by Date: Re: Question regarding to store file system metadata in database
• Next by Date: Re: [PATCH] scm: fold __scm_send() into scm_send()
• Previous by thread: Re: [PATCH 04/23] driver core: platform_get_irq*(): return -ENXIO on error
• Next by thread: [GIT PATCH] USB fixes and patches for 2.6.16
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]