On Sat, Mar 18, 2006 at 10:50:42PM -0500, Lee Revell wrote:
> On Sun, 2006-03-19 at 10:34 +0800, Wu Fengguang wrote:
> > Since the VM_MAX_READAHEAD is greatly enlarged and the algorithm become more
> > complex, it becomes necessary to insert some cond_resched() calls in the
> > read-ahead path.
>
> Do you have any numbers on this (say, from Ingo's latency tracer)? Have
> you confirmed it's not a latency regression with the default settings?
Now I have some from Ingo's latency tracer. When doing 1M sized readaheads,
the original kernel have ~5ms latency. This patch reduced that number to ~1ms.
The trace data are collected on the following command:
cp 3G_sparse_file /dev/null
The resulted maximum latencies are:
wfg ~% head -n5 latency_trace1
preemption latency trace v1.1.5 on 2.6.16
--------------------------------------------------------------------
latency: 1169 us, #319/319, CPU#0 | (M:server VP:0, KP:0, SP:0 HP:0 #P:1)
-----------------
| task: xmms-5077 (uid:1000 nice:0 policy:0 rt_prio:0)
wfg ~% head -n5 latency_trace2
preemption latency trace v1.1.5 on 2.6.16
--------------------------------------------------------------------
latency: 4835 us, #14102/14102, CPU#0 | (M:server VP:0, KP:0, SP:0 HP:0 #P:1)
-----------------
| task: xmms-5065 (uid:1000 nice:0 policy:0 rt_prio:0)
The folloing commands show that the 4835us latency is mainly caused by
__do_page_cache_readahead(): from 575us to 1723us
mpage_readpages(): from 1724us to 4795us
wfg ~% grep readahead latency_trace1
wfg ~% grep readpages latency_trace1
wfg ~% grep readahead latency_trace2
cp-5068 0dn.. 575us : _read_lock_irq (__do_page_cache_readahead)
cp-5068 0dn.. 576us : radix_tree_lookup_node (__do_page_cache_readahead)
cp-5068 0dn.. 576us : _read_unlock_irq (__do_page_cache_readahead)
cp-5068 0dn.. 577us : __alloc_pages (__do_page_cache_readahead)
cp-5068 0dn.. 580us : _read_lock_irq (__do_page_cache_readahead)
cp-5068 0dn.. 580us : radix_tree_lookup_node (__do_page_cache_readahead)
cp-5068 0dn.. 581us : _read_unlock_irq (__do_page_cache_readahead)
cp-5068 0dn.. 581us : __alloc_pages (__do_page_cache_readahead)
cp-5068 0dn.. 583us : _read_lock_irq (__do_page_cache_readahead)
......[899 LINES SKIPPED]
cp-5068 0dn.. 1712us : radix_tree_lookup_node (__do_page_cache_readahead)
cp-5068 0dn.. 1712us : _read_unlock_irq (__do_page_cache_readahead)
cp-5068 0dn.. 1713us : __alloc_pages (__do_page_cache_readahead)
cp-5068 0dn.. 1715us : _read_lock_irq (__do_page_cache_readahead)
cp-5068 0dn.. 1716us : radix_tree_lookup_node (__do_page_cache_readahead)
cp-5068 0dn.. 1716us : _read_unlock_irq (__do_page_cache_readahead)
cp-5068 0dn.. 1716us : __alloc_pages (__do_page_cache_readahead)
cp-5068 0dn.. 1719us : _read_lock_irq (__do_page_cache_readahead)
cp-5068 0dn.. 1719us : radix_tree_lookup_node (__do_page_cache_readahead)
cp-5068 0dn.. 1719us : _read_unlock_irq (__do_page_cache_readahead)
cp-5068 0dn.. 1720us : __alloc_pages (__do_page_cache_readahead)
cp-5068 0dn.. 1722us : _read_lock_irq (__do_page_cache_readahead)
cp-5068 0dn.. 1723us : _read_unlock_irq (__do_page_cache_readahead)
cp-5068 0dn.. 1723us : read_pages (__do_page_cache_readahead)
cp-5068 0dn.. 4800us : readahead_cache_hit (do_generic_mapping_read)
wfg ~% grep readpages latency_trace2
cp-5068 0dn.. 1724us : ext3_readpages (read_pages)
cp-5068 0dn.. 1724us : mpage_readpages (ext3_readpages)
cp-5068 0dn.. 1725us : add_to_page_cache (mpage_readpages)
cp-5068 0dn.. 1728us : do_mpage_readpage (mpage_readpages)
cp-5068 0dn.. 1742us : add_to_page_cache (mpage_readpages)
cp-5068 0dn.. 1744us : do_mpage_readpage (mpage_readpages)
cp-5068 0dn.. 1753us : add_to_page_cache (mpage_readpages)
cp-5068 0dn.. 1755us : do_mpage_readpage (mpage_readpages)
cp-5068 0dn.. 1764us : add_to_page_cache (mpage_readpages)
......[508 LINES SKIPPED]
cp-5068 0dn.. 4716us : do_mpage_readpage (mpage_readpages)
cp-5068 0dn.. 4726us : add_to_page_cache (mpage_readpages)
cp-5068 0dn.. 4728us : do_mpage_readpage (mpage_readpages)
cp-5068 0dn.. 4737us : add_to_page_cache (mpage_readpages)
cp-5068 0dn.. 4739us : do_mpage_readpage (mpage_readpages)
cp-5068 0dn.. 4748us : __pagevec_lru_add (mpage_readpages)
cp-5068 0dn.. 4750us : add_to_page_cache (mpage_readpages)
cp-5068 0dn.. 4752us : do_mpage_readpage (mpage_readpages)
cp-5068 0dn.. 4761us : add_to_page_cache (mpage_readpages)
cp-5068 0dn.. 4763us : do_mpage_readpage (mpage_readpages)
cp-5068 0dn.. 4772us : add_to_page_cache (mpage_readpages)
cp-5068 0dn.. 4774us : do_mpage_readpage (mpage_readpages)
cp-5068 0dn.. 4784us : add_to_page_cache (mpage_readpages)
cp-5068 0dn.. 4785us : do_mpage_readpage (mpage_readpages)
cp-5068 0dn.. 4795us : __pagevec_lru_add (mpage_readpages)
Cheers,
Wu
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
