Re: [PATCH]use kzalloc in vfs where appropriate

Am Montag, 20. März 2006 14:08 schrieb Denis Vlasenko:
> On Monday 20 March 2006 09:25, Pekka Enberg wrote:
> > > Rewriting the test as:
> > > n!=0 && n > INT_MAX / size
> > > saves the division because size is much likelier to be a constant, and indeed
> > > the code is better:
> > >
> > >         cmpq    $268435455, %rax
> > >         movq    $0, 40(%rsp)
> > >         ja      .L313
> > >
> > > Is there anything I am missing?
> 
> You may drop "n!=0" part, but you must check size!=0.
> Since if size is 0, kcalloc returns NULL, then

Why? size == 0 is a bug. We want to oops here.

	Regards
		Oliver
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH]use kzalloc in vfs where appropriate
  - From: Pekka J Enberg <[email protected]>

References:
- [PATCH]use kzalloc in vfs where appropriate
  - From: Oliver Neukum <[email protected]>
- Re: [PATCH]use kzalloc in vfs where appropriate
  - From: "Pekka Enberg" <[email protected]>
- Re: [PATCH]use kzalloc in vfs where appropriate
  - From: Denis Vlasenko <[email protected]>

Prev by Date: Re: DoS with POSIX file locks?
Next by Date: Re: [PATCH]use kzalloc in vfs where appropriate
Previous by thread: Re: [PATCH]use kzalloc in vfs where appropriate
Next by thread: Re: [PATCH]use kzalloc in vfs where appropriate
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]