Re: [PATCH] fix potential null pointer deref in quota

  Hello,

> The coverity checker noticed that we may pass a NULL super_block to
> do_quotactl() that dereferences it.
> Dereferencing NULL pointers is bad medicine, better check and fail 
> gracefully.
  Umm, when do you think we can dereference NULL pointer to a super_block?
check_quotactl_valid() allows sb==NULL only in the case of Q_SYNC command.
And that is handled in do_quotactl() correctly even if sb==NULL...

								Honza

-- 
Jan Kara <[email protected]>
SuSE CR Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] fix potential null pointer deref in quota
    • From: "Jesper Juhl" <[email protected]>

• References:
  • [PATCH] fix potential null pointer deref in quota
    • From: Jesper Juhl <[email protected]>

• Prev by Date: [patch] tux3-2.6.16-A0
• Next by Date: [patch] exec-shield-nx-2.6.16
• Previous by thread: Re: [PATCH] fix potential null pointer deref in quota
• Next by thread: Re: [PATCH] fix potential null pointer deref in quota
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]